Attention is currently required from: Angel Pons, Felix Held.
The thunderbolt-to-ethernet adapter is detected by the kernel:
[ 835.495393] thunderbolt 0-1: new device found, vendor=0x1
[ 835.495408] thunderbolt 0-1: Apple, Inc. Thunderbolt to Gigabit
The network interface wasn't created though, so I couldn't test the
adapter. No idea if it's linux or coreboot, but I think it's linux issue.
Was the Thunderbolt-to-Ethernet adapter plugged in before booting, or was it plugged in afterwards? […]
Patch Set #36, Line 27:
Type not needed
I think macOS wants at least 64M here
I don't know what macOS wants but corebooting a macbook to then turn it into a hackintosh to use macOS on it sounds a bit silly anyway. :)
But sure, why not.
# SandyBridge MRC Scrambler Seed values
896 32 r 0 mrc_scrambler_seed
928 32 r 0 mrc_scrambler_seed_s3
960 16 r 0 mrc_scrambler_seed_chk
This is only needed when using MRC. […]
2 0 Enable
2 1 Disable
This enumeration is unused, please drop
11 0 32M
11 1 64M
11 2 96M
11 3 128M
11 4 160M
11 5 192M
11 6 224M
Add all possible choices for `gfx_uma_size`: […]
Patch Set #36, Line 68:
This part of the comment is redundant, I'd drop it.
Patch Set #36, Line 10:
// OEM revision
I'd drop this comment
Patch Set #36, Line 6:
Missing: #include <types.h> […]
nit: Add another tab so that the arguments start on the same column
To view, visit change 32604. To unsubscribe, or for help writing mail filters, visit settings.