Attention is currently required from: Angel Pons, Felix Held.

11 comments:

Commit Message:

- Thunderbolt
The thunderbolt-to-ethernet adapter is detected by the kernel:
    [  835.495393] thunderbolt 0-1: new device found, vendor=0x1
                   device=0x8003
    [  835.495408] thunderbolt 0-1: Apple, Inc. Thunderbolt to Gigabit
                   Ethernet Adapter
The network interface wasn't created though, so I couldn't test the
adapter. No idea if it's linux or coreboot, but I think it's linux issue.

Was the Thunderbolt-to-Ethernet adapter plugged in before booting, or was it plugged in afterwards? […]

Afterwards.

File Documentation/mainboard/apple/macbookair5_2.md:
- Patch Set #36, Line 139: usb
  USB
  Done
File src/mainboard/apple/macbookair5_2/Kconfig:
- Patch Set #36, Line 27: string
  Type not needed
  Done
File src/mainboard/apple/macbookair5_2/cmos.default:
- Patch Set #36, Line 3: 32M
  I think macOS wants at least 64M here
  I don't know what macOS wants but corebooting a macbook to then turn it into a hackintosh to use macOS on it sounds a bit silly anyway. :)
  But sure, why not.
File src/mainboard/apple/macbookair5_2/cmos.layout:
- Patch Set #36, Line 29:
```
# SandyBridge MRC Scrambler Seed values
896	32	r	0	mrc_scrambler_seed
928	32	r	0	mrc_scrambler_seed_s3
960	16	r	0	mrc_scrambler_seed_chk
```
  This is only needed when using MRC. […]
  Done
- Patch Set #36, Line 42:
```
2	0	Enable
2	1	Disable
```
  This enumeration is unused, please drop
  Done
- Patch Set #36, Line 58:
```
11	0	32M
11	1	64M
11	2	96M
11	3	128M
11	4	160M
11	5	192M
11	6	224M
```
  Add all possible choices for `gfx_uma_size`: […]
  Done
File src/mainboard/apple/macbookair5_2/devicetree.cb:
- Patch Set #36, Line 68: PCI-LPC bridge
  This part of the comment is redundant, I'd drop it.
  Done
File src/mainboard/apple/macbookair5_2/dsdt.asl:
- Patch Set #36, Line 10: // OEM revision
  I'd drop this comment
  Done
File src/mainboard/apple/macbookair5_2/early_init.c:
- Patch Set #36, Line 6: #include <southbridge/intel/common/gpio.h>
  Missing: #include <types.h> […]
  Done
File src/mainboard/apple/macbookair5_2/mainboard.c:
- Patch Set #36, Line 9:
```
GMA_INT15_PANEL_FIT_DEFAULT,
				GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
```
  nit: Add another tab so that the arguments start on the same column
  Done

To view, visit change 32604. To unsubscribe, or for help writing mail filters, visit settings.