Attention is currently required from: Angel Pons, Benjamin Doron, Felix Singer, Jérémy Compostella, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59874?usp=email )
Change subject: src/arch/x86/c_start.S: Add proper x86_64 code ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
Patchset:
PS5: I think after the commit message is updated, this should be good to merge.
File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/59874/comment/70a4f29e_8f5f6b7a : PS2, Line 66: /** poison the stack. Code should not count on the : * stack being full of zeros. This stack poisoning : * recently uncovered a bug in the broadcast SIPI : * code. : */
To avoid duplication, the comment could be put outside the if-else statement.
This patch doesn't touch the comment, so while the comment is true, It doesn't need to be done in this patch.
https://review.coreboot.org/c/coreboot/+/59874/comment/99d28800_98eeead9 : PS2, Line 99: push_cpu_info : : #if CONFIG(CPU_INFO_V2) : /* Allocate the per_cpu_segment_data on the stack */ : push_per_cpu_segment_data : : #if ENV_X86_64 : /* : * Update the BSP's per_cpu_segment_descriptor to point to the : * per_cpu_segment_data that was allocated on the stack. : */ : set_segment_descriptor_base $per_cpu_segment_descriptors, %esp : : movabs per_cpu_segment_selector, %rax : mov %eax, %gs : #else : /* : * Update the BSP's per_cpu_segment_descriptor to point to the : * per_cpu_segment_data that was allocated on the stack. : */ : set_segment_descriptor_base $per_cpu_segment_descriptors, %esp : : mov per_cpu_segment_selector, %eax : mov %eax, %gs : #endif Add a comment about removing all of this in the commit message?