Attention is currently required from: Angel Pons, Benjamin Doron, Felix Singer, Jérémy Compostella, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.
Patch set 5:Code-Review +2
3 comments:
Patchset:
I think after the commit message is updated, this should be good to merge.
File src/arch/x86/c_start.S:
/** poison the stack. Code should not count on the
* stack being full of zeros. This stack poisoning
* recently uncovered a bug in the broadcast SIPI
* code.
*/
To avoid duplication, the comment could be put outside the if-else statement.
This patch doesn't touch the comment, so while the comment is true, It doesn't need to be done in this patch.
push_cpu_info
#if CONFIG(CPU_INFO_V2)
/* Allocate the per_cpu_segment_data on the stack */
push_per_cpu_segment_data
#if ENV_X86_64
/*
* Update the BSP's per_cpu_segment_descriptor to point to the
* per_cpu_segment_data that was allocated on the stack.
*/
set_segment_descriptor_base $per_cpu_segment_descriptors, %esp
movabs per_cpu_segment_selector, %rax
mov %eax, %gs
#else
/*
* Update the BSP's per_cpu_segment_descriptor to point to the
* per_cpu_segment_data that was allocated on the stack.
*/
set_segment_descriptor_base $per_cpu_segment_descriptors, %esp
mov per_cpu_segment_selector, %eax
mov %eax, %gs
#endif
Add a comment about removing all of this in the commit message?
To view, visit change 59874. To unsubscribe, or for help writing mail filters, visit settings.