Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Angel Pons, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 187:
(11 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/92c9da14_771908df PS187, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/db996a6a_cd49a054 PS187, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/aba80c5e_58ae6184 PS187, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/b1816787_68c108ac PS187, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/0b7768b7_86c9cdc2 PS187, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/8e27d4c1_92d22c64 PS187, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/55acba1a_701b2549 PS187, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/f52d8b0a_c90f0598 PS187, Line 97: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/15bc8071_ac337001 PS187, Line 120: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/9c4c9b53_85f481c9 PS187, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132397): https://review.coreboot.org/c/coreboot/+/35523/comment/d28c901f_555ce417 PS187, Line 159: if (gnvs) { braces {} are not necessary for single statement blocks