Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43161 )
Change subject: mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz ......................................................................
mb/google/vilboz: Fix variant ID for v3+ schematics for vilboz
At this moment, Vilboz board version is 1 and it according to v3+ schematics, however WiFi power enable is active high. This change sets VARIANT_MIN_BOARD_ID_V3_SCHEMATICS for Vilboz as 1 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW as 2.
BUG=b:160547115 BRANCH=None TEST=flash the bios to vilboz DUT and test WIFI module
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I9699bb839a801ab7d14c38b971ec28e3a322a997 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43161 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Kangheui Won: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index e24f78a..19225d7 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -142,13 +142,13 @@ default 3 if BOARD_GOOGLE_MORPHIUS default 2 if BOARD_GOOGLE_BERKNIP default 3 if BOARD_GOOGLE_DALBOZ - default 2 if BOARD_GOOGLE_VILBOZ + default 1 if BOARD_GOOGLE_VILBOZ default 256
config VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW int default 3 if BOARD_GOOGLE_BERKNIP - default 3 if BOARD_GOOGLE_VILBOZ + default 2 if BOARD_GOOGLE_VILBOZ default VARIANT_MIN_BOARD_ID_V3_SCHEMATICS
endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ