Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go@228 PS1, Line 228: PCISlot{PCIAddr: PCIAddr{Dev: 0x1c, Func: 6}, writeEmpty: true, additionalComment: "PCIe Port #7"}, : PCISlot{PCIAddr: PCIAddr{Dev: 0x1c, Func: 7}, writeEmpty: true, additionalComment: "PCIe Port #8"}, These only exist on some variants. See int max_root_ports(void) in sb/intel/lynxpoint/pcie.c
https://review.coreboot.org/#/c/30890/1/util/autoport/lynxpoint.go@272 PS1, Line 272: RestoreDIRRoute(sb, "D31IR", uint16(inteltool.RCBA[0x3140])) : RestoreDIRRoute(sb, "D29IR", uint16(inteltool.RCBA[0x3144])) : RestoreDIRRoute(sb, "D28IR", uint16(inteltool.RCBA[0x3146])) : RestoreDIRRoute(sb, "D27IR", uint16(inteltool.RCBA[0x3148])) : RestoreDIRRoute(sb, "D26IR", uint16(inteltool.RCBA[0x314c])) : RestoreDIRRoute(sb, "D25IR", uint16(inteltool.RCBA[0x3150])) : RestoreDIRRoute(sb, "D22IR", uint16(inteltool.RCBA[0x315c])) : RestoreDIRRoute(sb, "D20IR", uint16(inteltool.RCBA[0x3160])) I typically leave this to reset default, or use the defaults on my platform. The ACPI _PRT tables are automatically generated so up to you if you want it here.