Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: soc/intel/tigerlake: log the memory part name ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45459/6/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/6/src/lib/spd_bin.c@182 PS6, Line 182: switch (dram_type) {
Since both functions switch on `dram_type`, couldn't the `len = *_SPD_PART_LEN` just go in here too […]
The slight (but important) difference in the case statements is that the cases in this switch statement is grouped based on the offset within the spd for the part string and not the length of the part name in the SPD. They may be the same, or this may have been a bug in the prior code where it didn't notice that an LPDDR3_JEDEC string was using a DDR4_SPD_PART_LEN size.
But I can change this slightly to remove that and merge the two routines.