View Change
1 comment:
File src/lib/spd_bin.c:
Patch Set #6, Line 182: switch (dram_type) {
Since both functions switch on `dram_type`, couldn't the `len = *_SPD_PART_LEN` just go in here too […]
The slight (but important) difference in the case statements is that the cases in this switch statement is grouped based on the offset within the spd for the part string and not the length of the part name in the SPD. They may be the same, or this may have been a bug in the prior code where it didn't notice that an LPDDR3_JEDEC string was using a DDR4_SPD_PART_LEN size.
But I can change this slightly to remove that and merge the two routines.
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 6
Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Thu, 17 Sep 2020 21:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment