Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46091 )
Change subject: mb/intel/adlrvp: Add ADL-P romstage mainboard code ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46091/8/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/46091/8/src/mainboard/intel/adlrvp/... PS8, Line 16: uintptr_t
why is this an uintptr_t? it's not really a pointer to anything
`size_t` is probably more appropriate here, for `spd_index` too
https://review.coreboot.org/c/coreboot/+/46091/7/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46091/7/src/mainboard/intel/adlrvp/... PS7, Line 8: register "SaGv" = "SaGv_Disabled"
Sounds good.
Sorry, I don't mean the FSP default, I mean the devicetree default; if you don't set the `SaGv` register, `SaGv_Disabled` is the default value because it's 0.