Patch set 8:Code-Review +1
2 comments:
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
Patch Set #8, Line 16: uintptr_t
why is this an uintptr_t? it's not really a pointer to anything
`size_t` is probably more appropriate here, for `spd_index` too
File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:
Patch Set #7, Line 8: register "SaGv" = "SaGv_Disabled"
Sounds good.
Sorry, I don't mean the FSP default, I mean the devicetree default; if you don't set the `SaGv` register, `SaGv_Disabled` is the default value because it's 0.
To view, visit change 46091. To unsubscribe, or for help writing mail filters, visit settings.