Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46090 )
Change subject: mb/google/dedede: refactor DPTF section for simpler overrides ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... PS2, Line 102: .pl2 = { : .min_power = 6000, : .max_power = 20000, : .time_window_min = 1 * MSECS_PER_SEC, : .time_window_max = 1 * MSECS_PER_SEC, : .granularity = 1000, : } I am a little lost. The pl2 here is same as pl2 in baseboard devicetree. If the purpose of this CL is not to override all the DPTF fields, why is it added here. Same for options.tsr[0..1].desc