Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43671 )
Change subject: mb/google/volteer: Create lindar variant ......................................................................
Patch Set 10:
(2 comments)
Patch Set 10: Code-Review+1
Could you help to review this? Thank you.
Could you please use the script ~/trunk/src/platform/dev/contrib/variant/create_coreboot_variant.sh to generate the initial version and then rebase your change based on the generated code? Please also use the create_coreboot_config.sh to generate the coreboot config.
https://review.coreboot.org/c/coreboot/+/43671/10/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/43671/10/src/mainboard/google/volte... PS10, Line 74: default "Lindar" if BOARD_GOOGLE_LINDAR Use tab and please follow the dictionary order.
https://review.coreboot.org/c/coreboot/+/43671/10/src/mainboard/google/volte... PS10, Line 110: default "lindar" if BOARD_GOOGLE_LINDAR Use tab and please follow the dictionary order.