3 Apr
2019
3 Apr
'19
4:48 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG@13 PS7, Line 13: panel
You write *screen* in the summary.
Done
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG@15 PS7, Line 15: Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com
Please remove this duplicate line.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/32134
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d
Gerrit-Change-Number: 32134
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 Apr 2019 04:48:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment