[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Allow including FSPT at specified offset

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43398 )

Change subject: drivers/intel/fsp2_0: Allow including FSPT at specified offset
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG@11 
PS1, Line 11: specify FSPT location in CBFS and user option to include FSPT.
> The FSP-T binary is not relocatable, it seems. So, it needs to be placed at a specific address in memory.

Documented where? If it's not documented, we should. It seems like
another violation of the spec.
> Placing it in CAR is probably not going to work, if FSP-T reinitializes CAR and erases its own code while doing so.

We already know that FSP-T is not always about setting up CAR. So it's
actually possible that Intel would implement such folly.