Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43398 ) Change subject: drivers/intel/fsp2_0: Allow including FSPT at specified offset ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG@11 PS1, Line 11: specify FSPT location in CBFS and user option to include FSPT.
The FSP-T binary is not relocatable, it seems. So, it needs to be placed at a specific address in memory.
Documented where? If it's not documented, we should. It seems like another violation of the spec.
Placing it in CAR is probably not going to work, if FSP-T reinitializes CAR and erases its own code while doing so.
We already know that FSP-T is not always about setting up CAR. So it's actually possible that Intel would implement such folly. -- To view, visit https://review.coreboot.org/c/coreboot/+/43398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I997c7465fd7ac56633c3e7e3fa5b95384dcf5ad2 Gerrit-Change-Number: 43398 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 13 Jul 2020 13:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment