Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35506 )
Change subject: trogdor: support mbn_version 6 with python build scripts
......................................................................
Patch Set 36:
(1 comment)
Looks like you've taking my suggestion in some parts of the patch here but not yet in other parts... please address the remaining open comments and indicate if you consider this ready for review again.
https://review.coreboot.org/c/coreboot/+/35506/36/util/qualcomm/createxbl.py
File util/qualcomm/createxbl.py:
https://review.coreboot.org/c/coreboot/+/35506/36/util/qualcomm/createxbl.py...
PS36, Line 269: secure_type = image_header_secflag, header_version = header_version )
You said 'Done' here but you didn't actually put it on a new line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I020d1e4d4f5c948948e1b39dd18af1d0e860c279
Gerrit-Change-Number: 35506
Gerrit-PatchSet: 36
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson
dianders@chromium.org
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rishabh Sharma
rishabh435@gmail.com
Gerrit-CC: ashk@codeaurora.org
Gerrit-Comment-Date: Thu, 06 Feb 2020 01:51:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment