Looks like you've taking my suggestion in some parts of the patch here but not yet in other parts... please address the remaining open comments and indicate if you consider this ready for review again.

View Change

1 comment:

• File util/qualcomm/createxbl.py:

  • Patch Set #36, Line 269: secure_type = image_header_secflag, header_version = header_version )

    You said 'Done' here but you didn't actually put it on a new line.

To view, visit change 35506. To unsubscribe, or for help writing mail filters, visit settings.