Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 41:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... PS40, Line 110: // ^^^GFX0.GLID (KLID)
?
Vendor BIOS calls this method inside the graphics device, which I need to rewrite or remove. The method is commented out here so that it isn't lost until I can do this.
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... PS40, Line 42: // If (CondRefOf (_SB.TPM.PTS))
?
Vendor BIOS calls the prepare-to-sleep method on the TPM's ACPI device. As I understand, coreboot generates the ACPI table for the TPM dynamically, this will either be removed or tagged as external.
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... PS40, Line 50: // Chipset specific sleep states
"common" isn't really "chipset specific", so maybe drop the comment?
Done
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/35523/40/src/mainboard/acer/aspire_... PS40, Line 34: /* Pin Complex (NID 0x12) */
Please remove these comments, they don't provide useful info
Done