Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33064 )
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33064/1/src/southbridge/intel/i82801ix/Kconf...
File src/southbridge/intel/i82801ix/Kconfig:
https://review.coreboot.org/#/c/33064/1/src/southbridge/intel/i82801ix/Kconf...
PS1, Line 21: select SOUTHBRIDGE_INTEL_COMMON_SPI if !BOARD_EMULATION_QEMU_X86_Q35
doesn't qemu support SPI?
You need a timer_monotonic_get implementation which qemu lacks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I563c69ce6337d46380f889f42633e858ac207916
Gerrit-Change-Number: 33064
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 31 May 2019 06:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment