Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33064
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI ......................................................................
sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI
This allows to use the CONFIG_CONSOLE_SPI_FLASH.
Change-Id: I563c69ce6337d46380f889f42633e858ac207916 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/i82801ix/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33064/1
diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index a269773..5edb8a1 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -18,6 +18,7 @@ bool select SOUTHBRIDGE_INTEL_COMMON select SOUTHBRIDGE_INTEL_COMMON_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_SPI if !BOARD_EMULATION_QEMU_X86_Q35 select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ select IOAPIC select HAVE_USBDEBUG
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33064 )
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33064/1/src/southbridge/intel/i82801ix/Kconf... File src/southbridge/intel/i82801ix/Kconfig:
https://review.coreboot.org/#/c/33064/1/src/southbridge/intel/i82801ix/Kconf... PS1, Line 21: select SOUTHBRIDGE_INTEL_COMMON_SPI if !BOARD_EMULATION_QEMU_X86_Q35 doesn't qemu support SPI?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33064 )
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33064/1/src/southbridge/intel/i82801ix/Kconf... File src/southbridge/intel/i82801ix/Kconfig:
https://review.coreboot.org/#/c/33064/1/src/southbridge/intel/i82801ix/Kconf... PS1, Line 21: select SOUTHBRIDGE_INTEL_COMMON_SPI if !BOARD_EMULATION_QEMU_X86_Q35
doesn't qemu support SPI?
You need a timer_monotonic_get implementation which qemu lacks.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33064 )
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI ......................................................................
Patch Set 1:
Actually with TSC_MONOTONIC_TIMER selected you get:
ICH SPI: Data transaction error SF: Failed to send command 9f: 1 flash size 0x80000 bytes SF: Detected Opaque HW-sequencing with sector size 0x100, total 0x80000 SF size 0x80000 does not correspond to CONFIG_ROM_SIZE 0x200000!!
Maybe a better Kconfig like BOOT_DEVICE_NOT_SPI_FLASH could be used here? I think that also makes sense for some ich7 boards that feature LPC flash.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33064 )
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33064 )
Change subject: sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI ......................................................................
sb/intel/i82801ix: Select SOUTHBRIDGE_INTEL_COMMON_SPI
This allows to use the CONFIG_CONSOLE_SPI_FLASH.
Change-Id: I563c69ce6337d46380f889f42633e858ac207916 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33064 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/southbridge/intel/i82801ix/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index a269773..5edb8a1 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -18,6 +18,7 @@ bool select SOUTHBRIDGE_INTEL_COMMON select SOUTHBRIDGE_INTEL_COMMON_SMBUS + select SOUTHBRIDGE_INTEL_COMMON_SPI if !BOARD_EMULATION_QEMU_X86_Q35 select SOUTHBRIDGE_INTEL_COMMON_RCBA_PIRQ select IOAPIC select HAVE_USBDEBUG
-
Arthur Heymans (Code Review) -
Patrick Rudolph (Code Review)