Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40962 )
Change subject: superio/*: Standardise config state entry/exit prototype in pnp_ops.h ......................................................................
Patch Set 7:
If you look at some generated mb/static.c file, we already have PNP device nodes in romstage, and I think you can constify struct device * everywhere in pnp_enter/exit_xx declarations?
That doesn't solve the problem for bootblock and the serial console usually gets configured in bootblock.
Longterm I think SIMPLE_DEVICE and pci_devfn_t and pnp_devfn_t could go away.
I'd like to see that, but I'm not sure how feasible this would be. Haven't had a look how difficult it would be to solve this for bootblock.