If you look at some generated mb/static.c file, we already have PNP device nodes in romstage, and I think you can constify struct device * everywhere in pnp_enter/exit_xx declarations?

That doesn't solve the problem for bootblock and the serial console usually gets configured in bootblock.

Longterm I think SIMPLE_DEVICE and pci_devfn_t and pnp_devfn_t could go away.

I'd like to see that, but I'm not sure how feasible this would be. Haven't had a look how difficult it would be to solve this for bootblock.

View Change

To view, visit change 40962. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4e742edb17ca73c01ff7b552e00e18acc6779dd
Gerrit-Change-Number: 40962
Gerrit-PatchSet: 7
Gerrit-Owner: Keith Hui <buurin@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Comment-Date: Thu, 04 Jun 2020 18:13:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment