Attention is currently required from: Paul Menzel, Angel Pons. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 35:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/32673/comment/7eb27963_9b06bb36 PS25, Line 10:
Please add a note, if you used autoport or some other board as template.
Done
File Documentation/mainboard/apple/macbookpro10_1.md:
https://review.coreboot.org/c/coreboot/+/32673/comment/96b3565a_ea34d3e2 PS25, Line 34: Tianocore
TianoCore
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/5dfa9982_c22ebae2 PS25, Line 55: - Bad sound in headphones
Can you elaborate?
No such problem any more.
File Documentation/mainboard/apple/mbp101_board.jpg:
PS25:
Ah, not sure about that board, but on some others pulling those pins high is a must. […]
This one doesn't need it, marking as resolved.
File src/mainboard/apple/macbookpro10_1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/cd84ca3b_1e729715 PS22, Line 30: LVDS
Ack. […]
Done