Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37532 )
Change subject: northbridge: Don't use both of _ADR and _HID ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 1:
Patch Set 1:
(1 comment)
If you rebase on the latest code, I think this commit should go away.
Yes, I get the comment and code from that commit... Should I redo the comment or leave it because is already in the latest code?
What I'm saying is that it looked like your starting point is out of date, and this particular change has already gone in. If you run "git fetch && git rebase origin/master", then you'll no longer need this commit at all. OTOH if I'm misreading it, then you should change the commit message to match what this commit actually does.
Sorry, I'm in an accelerated git and gerrit course and a lot of things are new for me. I was pointed to start my bettong port in an old commit from Apr (f77f2c79c2bb898c123ffe89a0bd1acb5362afc5) because now the board is disabled. The commit I'm redoing (01787608670adec26fcea48173e18395e51c790e) with this patch is from Oct. I don't know how to import this new commit in my old branch... I guess is a rebase. I'm still learning to be able to contribute.