Patch Set 2:

Patch Set 1:

Patch Set 1:

(1 comment)

If you rebase on the latest code, I think this commit should go away.

Yes, I get the comment and code from that commit... Should I redo the comment or leave it because is already in the latest code?

What I'm saying is that it looked like your starting point is out of date, and this particular change has already gone in. If you run "git fetch && git rebase origin/master", then you'll no longer need this commit at all. OTOH if I'm misreading it, then you should change the commit message to match what this commit actually does.

Sorry, I'm in an accelerated git and gerrit course and a lot of things are new for me. I was pointed to start my bettong port in an old commit from Apr (f77f2c79c2bb898c123ffe89a0bd1acb5362afc5) because now the board is disabled. The commit I'm redoing (01787608670adec26fcea48173e18395e51c790e) with this patch is from Oct. I don't know how to import this new commit in my old branch... I guess is a rebase. I'm still learning to be able to contribute.

View Change

To view, visit change 37532. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48fb3e9e48893336416eb90f80957e5bd21d1711
Gerrit-Change-Number: 37532
Gerrit-PatchSet: 2
Gerrit-Owner: Jorge Fernandez
Gerrit-Reviewer: Jorge Fernandez
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Frans Hendriks <fhendriks@eltan.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 10 Dec 2019 07:55:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment