Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Matt DeVillier, Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35523
to look at the new patch set (#181).
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
mb/acer: Add Acer Aspire VN7-572G
Add initial support for Acer Aspire VN7-572G (Skylake-U).
Also note that there are two similar boards, Aspire VN7-792G and Aspire VN7-592G; both are Skylake-H. These are not supported (yet). Do not flash images intended for Aspire VN7-572G on those boards: the GPIOs and HSIO routing will be different and may risk damage to the hardware.
Working: - Payload - TianoCore (CorebootPayload or UefiPayload) - OS - Fedora 34 (kernel 5.12.5) - Windows 10 20H1 (bugs present - battery paging - perhaps fixed; abandoning testing) - Display (VBT partially matches vendor's configuration) - with FSP GOP - with IntelGopDriver (in payload: TianoCore) - with libgfxinit - HDMI display - Audio - Speakers and headphone jack - Internal microphone - HDMI audio - Devices - PCIe and SATA (unable to test NGFF) - USB ports (unable to test type-C, touchscreen and finger-printer) - TPM - Keyboard and touchpad - EC ACPI functionality - CMOS settings
In progress: - EC SMM functionality
Not working: - STM (breaks boot; by smihandler) - Requires hook to add resources - vboot (breaks boot) - See follow-up
Notes: - `tpm2_pcrallocate` to enable SHA256 PCR bank
Not implemented: - Optimus (see CB:28380, CB:40625 and CB:40628) - WMI
Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6 Signed-off-by: Benjamin Doron benjamin.doron00@gmail.com --- M src/mainboard/acer/Kconfig A src/mainboard/acer/aspire_vn7_572g/Kconfig A src/mainboard/acer/aspire_vn7_572g/Kconfig.name A src/mainboard/acer/aspire_vn7_572g/Makefile.inc A src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl A src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl A src/mainboard/acer/aspire_vn7_572g/acpi/brightness_levels.asl A src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl A src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl A src/mainboard/acer/aspire_vn7_572g/acpi/superio.asl A src/mainboard/acer/aspire_vn7_572g/acpi/thermal.asl A src/mainboard/acer/aspire_vn7_572g/board.fmd A src/mainboard/acer/aspire_vn7_572g/board_info.txt A src/mainboard/acer/aspire_vn7_572g/bootblock.c A src/mainboard/acer/aspire_vn7_572g/cmos.default A src/mainboard/acer/aspire_vn7_572g/cmos.layout A src/mainboard/acer/aspire_vn7_572g/data.vbt A src/mainboard/acer/aspire_vn7_572g/devicetree.cb A src/mainboard/acer/aspire_vn7_572g/die.c A src/mainboard/acer/aspire_vn7_572g/dsdt.asl A src/mainboard/acer/aspire_vn7_572g/ec.c A src/mainboard/acer/aspire_vn7_572g/gma-mainboard.ads A src/mainboard/acer/aspire_vn7_572g/gpio.c A src/mainboard/acer/aspire_vn7_572g/gpio_early.c A src/mainboard/acer/aspire_vn7_572g/hda_verb.c A src/mainboard/acer/aspire_vn7_572g/include/ec.h A src/mainboard/acer/aspire_vn7_572g/include/gpio.h A src/mainboard/acer/aspire_vn7_572g/mainboard.c A src/mainboard/acer/aspire_vn7_572g/romstage.c A src/mainboard/acer/aspire_vn7_572g/smihandler.c 30 files changed, 2,890 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35523/181