7 Jun
2019
7 Jun
'19
9:29 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )
Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/33250/5/src/superio/aspeed/common/acpi/super... File src/superio/aspeed/common/acpi/superio.asl:
https://review.coreboot.org/#/c/33250/5/src/superio/aspeed/common/acpi/super... PS5, Line 18: Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard Resources */) // _HID: Hardware ID this is a bit odd mix of comment styles
--
To view, visit https://review.coreboot.org/c/coreboot/+/33250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934
Gerrit-Change-Number: 33250
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Jun 2019 19:29:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment