Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 34: default n Maybe add a help line saying that this option will be removed when the binaries are merged into the blobs repo. You could even add a pointer to the commit for the binaries.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 153: if MERLINFALCON_BINARIES_PRESENT : config VGA_BIOS_FILE : string : default "3rdparty/blobs/soc/amd/merlinfalcon/VBIOS.bin" if SOC_AMD_MERLINFALCON : default "3rdparty/blobs/soc/amd/stoneyridge/VBIOS.bin" : endif # MERLINFALCON_BINARIES_PRESENT : : if !MERLINFALCON_BINARIES_PRESENT The if clause isn't needed. Just add the one line:
default "3rdparty/blobs/soc/amd/merlinfalcon/VBIOS.bin" if SOC_AMD_MERLINFALCON && MERLINFALCON_BINARIES_PRESENT
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 210: MERLINFALCON_BINARIES_PRESENT same comment as above.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 347: <codename> Stoneyridge?