Attention is currently required from: Aaron Durbin, Furquan Shaikh, Julius Werner.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email )
Change subject: util: cbfstool: Add '%<alignment>' in flashmap descriptor
......................................................................
Patch Set 13:
(3 comments)
File util/cbfstool/default.fmd:
https://review.coreboot.org/c/coreboot/+/37262/comment/aae0ba6a_87af6349 :
PS13, Line 15:
There should be no space here, right? (I mean, I guess it may still work if there is, but I think it […]
Done
File util/cbfstool/fmd_parser.y:
https://review.coreboot.org/c/coreboot/+/37262/comment/45f20ee6_7d9b9ab9 :
PS13, Line 103: | region_flag ',' region_flags { $$.v = $1.v | $3.v; };
I think that's a left over when I implemented the 'UNALIGNED' flags and yes we should remove it. […]
Removed the ','
File util/cbfstool/fmd_scanner.l:
https://review.coreboot.org/c/coreboot/+/37262/comment/90814873_55e4c48e :
PS13, Line 31: . return *yytext;
No it doesn't. Lex is for parsing string to tokens, and anything not listed will fall into the `. […]
',' is removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9
Gerrit-Change-Number: 37262
Gerrit-PatchSet: 13
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Thu, 15 Jun 2023 05:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment