[coreboot-gerrit] [XL] Change in coreboot[master]: util: cbfstool: Add '%<alignment>' in flashmap descriptor

[Hung-Te Lin (Code Review)]

Attention is currently required from: Aaron Durbin, Furquan Shaikh, Julius Werner.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email )

Change subject: util: cbfstool: Add '%<alignment>' in flashmap descriptor
......................................................................


Patch Set 13:

(3 comments)

File util/cbfstool/default.fmd:

https://review.coreboot.org/c/coreboot/+/37262/comment/aae0ba6a_87af6349 :
PS13, Line 15:
> There should be no space here, right? (I mean, I guess it may still work if there is, but I think it […]
> Done

File util/cbfstool/fmd_parser.y:

https://review.coreboot.org/c/coreboot/+/37262/comment/45f20ee6_7d9b9ab9 :
PS13, Line 103: 	| region_flag ',' region_flags { $$.v = $1.v | $3.v; };
> I think that's a left over when I implemented the 'UNALIGNED' flags and yes we should remove it. […]
> Removed the ','

File util/cbfstool/fmd_scanner.l:

https://review.coreboot.org/c/coreboot/+/37262/comment/90814873_55e4c48e :
PS13, Line 31: .                           return *yytext;
> No it doesn't. Lex is for parsing string to tokens, and anything not listed will fall into the `. […]
> ',' is removed.