Attention is currently required from: Aaron Durbin, Furquan Shaikh, Julius Werner.

View Change

3 comments:

• File util/cbfstool/default.fmd:

  • Patch Set #13, Line 15:

    There should be no space here, right? (I mean, I guess it may still work if there is, but I think it […]

    Done

• File util/cbfstool/fmd_parser.y:

  • Patch Set #13, Line 103: | region_flag ',' region_flags { $$.v = $1.v | $3.v; };

    I think that's a left over when I implemented the 'UNALIGNED' flags and yes we should remove it. […]

    Removed the ','

• File util/cbfstool/fmd_scanner.l:

  • Patch Set #13, Line 31: . return *yytext;

    No it doesn't. Lex is for parsing string to tokens, and anything not listed will fall into the `. […]

    ',' is removed.

To view, visit change 37262. To unsubscribe, or for help writing mail filters, visit settings.