Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39124 )
Change subject: mb/kontron/986lcd-m: Select FIXED_UART_FOR_CONSOLE ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39124/1//COMMIT_MSG@9 PS1, Line 9: hardcoded
Setting `TTYS0_BASE` won’t have any effect, or am I missing anything?
If TTYS0_BASE is 0x3f8, data will flow out of the first port; if 0x2f8, the second.
There are few boards where the prompt makes sense, this seems to be one of them ;)
There's a lot of confusion around it. Historically, UART_FOR_CONSOLE had two competing implementations:
* (What I think is correct:) If a board has more than one UART, each UART is assigned a port range in the usual order (3f8, 2f8, 3e8, 2e8). UART_FOR_CONSOLE selects to which port the console goes. * TTYS0_BASE is assigned to the port the developer used for debugging (not sure if any board still does that, but I recall that I saw something like that).
Not so long ago, a third interpretation was added. Intel repurposed this Kconfig to select the port of a board to select the port of their SoC instead.
Maybe it's time to document all this... but I'm not a fan to document something that wouldn't need documentation if it were fixed instead.