Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for version 3.2 ......................................................................
Patch Set 5:
(3 comments)
Patch Set 5:
(6 comments)
Patch Set 1:
(6 comments)
Patrick,
- Line 561: "_weak" so that it can be if needed for som platform/soc
- Line 829: I agree that the entry point should be added as as specified in SMBIOS 3.0. it would be more disruptive in this CL, as the change will also need to go in other other files where the table entry are used. I suggest having a later patch and review exclusively for the table entry update.
It's not disruptive. Just a few lines to add in this file. No need to update the callers.
https://review.coreboot.org/#/c/32090/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32090/5//COMMIT_MSG@10 PS5, Line 10: platform/mosys I can't find it on Gerrit.
https://review.coreboot.org/#/c/32090/5//COMMIT_MSG@13 PS5, Line 13: thread It does more than that.
https://review.coreboot.org/#/c/32090/5/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32090/5/src/arch/x86/smbios.c@279 PS5, Line 279: ddr_frequency Are you sure that all callers provide the value in MHz?