Patch Set 5:

(6 comments)

Patch Set 1:

(6 comments)

Patrick,
- Line 561: "_weak" so that it can be if needed for som platform/soc
- Line 829: I agree that the entry point should be added as as specified in SMBIOS 3.0. it would be more disruptive in this CL, as the change will also need to go in other other files where the table entry are used. 
  I suggest having a later patch and review exclusively for the table entry update.

It's not disruptive. Just a few lines to add in this file. No need to update the callers.

View Change

3 comments:

• Commit Message:

  • Patch Set #5, Line 10: platform/mosys

    I can't find it on Gerrit.

  • Patch Set #5, Line 13: thread

    It does more than that.

• File src/arch/x86/smbios.c:

  • Patch Set #5, Line 279: ddr_frequency

    Are you sure that all callers provide the value in MHz?

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.