Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 118:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl:
PS62:
All functionality seems to work now. I can work on documenting it now. […]
Done, although there are still some parts that I'm unsure of.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 155: Method (_Q1C, 0, NotSerialized) // _Qxx: EC Query, xx=0x00-0xFF
Well, you can apply ACPI overrides even when using the vendor BIOS: https://wiki.archlinux. […]
I don't see any boards with comments more explanatory than the default comments from the decompiler. Marking as done.
https://review.coreboot.org/c/coreboot/+/35523/65/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/35523/65/src/mainboard/acer/aspire_... PS65, Line 674: /* WBEC: Calls SMI function 0x11 */
These functions don't seem to be necessary for correct functioning. […]
I could possibly attempt to debug the vendor firmware's SMM code at some point in the future (DCI and maybe the UDK debugger are the only possible ways to do it, I'm assuming), but as stated, these functions don't seem to be necessary for correct functioning.
Marking as done.
https://review.coreboot.org/c/coreboot/+/35523/87/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/35523/87/src/mainboard/acer/aspire_... PS87, Line 110: 0x02050010, : 0x02040f20,
These look out of place, but were located after the previous beep_verbs. […]
Seems to work correctly. Marking as done.