12 Nov
2022
12 Nov
'22
10:57 p.m.
Attention is currently required from: Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11-lga1151-series: fix cmos layout and add default config ......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/supermicro/x11-lga1151-series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35526/comment/42287130_289b2900 PS18, Line 33: 400 1 e 2 hyper_threading
So, hyper_threading uses enum 2, which means `0 = Enable` and `1 = Disable`. This is backwards. […]
CB:69491
--
To view, visit https://review.coreboot.org/c/coreboot/+/35526
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10b0aa71fa7916b01e93e16cbd81e427fd14f6a4
Gerrit-Change-Number: 35526
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 12 Nov 2022 21:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment