Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38645 )
Change subject: drivers/intel/gma/edid: Use unsigned type for count variable
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38645/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38645/1//COMMIT_MSG@12
PS1, Line 12: .string "i"
: .byte 0x1
: .byte 0x44
: - .byte 0x6
: - .long 0x4d
: + .byte 0xf
: + .long 0x60
: .long .LLST25
: .long .LVUS25
: .uleb128 0xe
It’s just to show, that the compiler is unable to take advantage of the more specific type informati […]
But you show a hunk of the diff here without context. Something changed
and I don't understand what. What segment is this? does it end up in the
final binary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80
Gerrit-Change-Number: 38645
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 05 Feb 2020 17:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment