Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38203 )
Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38203/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38203/3//COMMIT_MSG@9 PS3, Line 9: nable the discrete VGA adapter (either HD-8570M or R5-M230) on Lenovo G505S. : It doesn't bring any downsides for Lenovo G505S without a discrete VGA adapter:
Please wrap at 72 characters
Done.
https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/Kconfig:
https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... PS3, Line 33: select PCIEXP_L1_SUB_STATE : select PCIEXP_ASPM : select PCIEXP_COMMON_CLOCK : select PCIEXP_CLK_PM
It qualifies for a separate patch
Done. Will retest without these configs enabled - and, if dGPU still works, will leave them disabled by default.