Change in coreboot[master]: lenovo/g505s: enable the discrete VGA adapter

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Mike Banon (Code Review)

5 Jan 2020 5 Jan '20

8:07 p.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

lenovo/g505s: enable the discrete VGA adapter

Enable the discrete VGA adapter (either HD-8570M or R5-M230) on Lenovo G505S. It doesn't bring any downsides for Lenovo G505S without a discrete VGA adapter: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/KVXP...

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e --- M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/devicetree.cb 2 files changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38203/1

diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 6ffe508..68782dc 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -30,6 +30,11 @@ select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_4096 select GFXUMA + select MAINBOARD_HAS_MULTIPLE_VGA_ADAPTERS + select PCIEXP_L1_SUB_STATE + select PCIEXP_ASPM + select PCIEXP_COMMON_CLOCK + select PCIEXP_CLK_PM select NO_UART_ON_SUPERIO

config MAINBOARD_DIR diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb index 623a78b..8a4ce94 100644 --- a/src/mainboard/lenovo/g505s/devicetree.cb +++ b/src/mainboard/lenovo/g505s/devicetree.cb @@ -27,7 +27,7 @@ device pci 0.2 on end # IOMMU device pci 1.0 on end # Internal Graphics P2P bridge 0x99XX device pci 1.1 on end # Internal Multimedia - device pci 2.0 off end + device pci 2.0 on end # Discrete Graphics PCI bus 0x666X device pci 3.0 off end device pci 4.0 on end # PCIE MINI0 device pci 5.0 on end # PCIE MINI1

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Michał Żygowski (Code Review)

17 Apr 17 Apr

2:53 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38203/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38203/3//COMMIT_MSG@9 PS3, Line 9: nable the discrete VGA adapter (either HD-8570M or R5-M230) on Lenovo G505S. : It doesn't bring any downsides for Lenovo G505S without a discrete VGA adapter: Please wrap at 72 characters

https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/Kconfig:

https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... PS3, Line 33: select PCIEXP_L1_SUB_STATE : select PCIEXP_ASPM : select PCIEXP_COMMON_CLOCK : select PCIEXP_CLK_PM It qualifies for a separate patch

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Apr 2020 12:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

6:07 p.m.

Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38203

to look at the new patch set (#4).

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

lenovo/g505s: enable the discrete VGA adapter

Enable the discrete VGA adapter (HD-8570M / R5-M230) on Lenovo G505S. It doesn't bring any downsides for Lenovo G505S without a discrete VGA: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/KVXP...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38203/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

6:10 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38203/3//COMMIT_MSG Commit Message:

...

Please wrap at 72 characters

Done.

https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/Kconfig:

https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... PS3, Line 33: select PCIEXP_L1_SUB_STATE : select PCIEXP_ASPM : select PCIEXP_COMMON_CLOCK : select PCIEXP_CLK_PM

...

It qualifies for a separate patch

Done. Will retest without these configs enabled - and, if dGPU still works, will leave them disabled by default.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Apr 2020 16:10:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: comment

Mike Banon (Code Review)

19 Apr 19 Apr

6:17 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/Kconfig:

https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... PS3, Line 33: select PCIEXP_L1_SUB_STATE : select PCIEXP_ASPM : select PCIEXP_COMMON_CLOCK : select PCIEXP_CLK_PM

...

Done. […]

Yes, turned out discrete GPU works fine even without these PCIEXP options - so no need for a separate patch

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 19 Apr 2020 16:17:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Comment-In-Reply-To: Mike Banon mikebdp2@gmail.com Gerrit-MessageType: comment

Mike Banon (Code Review)

27 Oct 27 Oct

5:49 p.m.

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

Abandoned

Abandoned in favor of a fresh CB:58653

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

Mike Banon (Code Review)

5:54 p.m.

Mike Banon has restored this change. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: restore

Mike Banon (Code Review)

5:54 p.m.

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38203 )

Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................

Abandoned

Abandoned in favor of a fresh CB:58653 . Thank you for your comments, I will move the unresolved ones to this new change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e Gerrit-Change-Number: 38203 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

911

days inactive

1572

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

Michał Żygowski (Code Review)
Mike Banon (Code Review)