Attention is currently required from: Martin L Roth, Paul Menzel, Angel Pons.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 51:
(9 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/32673/comment/b0529d68_03903c79 PS43, Line 10: and Retina Display.
Some words fit on the line above?
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/cd88d641_060a8440 PS43, Line 12: monent
moment
Done
File Documentation/mainboard/apple/macbookpro10_1.md:
https://review.coreboot.org/c/coreboot/+/32673/comment/4ee85a7f_3d299eb8 PS43, Line 19: this script
the script `get_macbook_ramcfg`
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/36b5c29a_bce2493a PS43, Line 23: ```console : $ cd util/inteltool : $ make -j4 : ```
I’d just add blank lines and indent by four spaces.
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/cec48296_abb2a7a2 PS43, Line 30: sudo ./inteltool -g | /path/to/get_macbook_ramcfg -m mbp101
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/895d7990_c0603527 PS43, Line 42: Yes
Why not bold as below?
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/91347dd2_e6777e92 PS43, Line 73: to coreboot
to *the* coreboot mailing list
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/0c1e1d10_6e332372 PS43, Line 97: - SeaBIOS, GRUB, TianoCore
Please add the versions.
in progress
File src/mainboard/apple/macbookpro10_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/22999dcc_bdfb7796 PS43, Line 96: die("Unsupported memory, RAMCFG=%d\n", ramcfg);
… Please contact the coreboot mailing list.
Done