Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common SATA driver
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/7/src/soc/intel/common/block/...
PS7, Line 7: static void sata_final(struct device *dev)
: {
: /* Set Bus Master */
: pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER);
: }
Not for this change, but I wonder if this should be done for all controllers i.e. […]
good feedback Furquan, let me come up with changes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c
Gerrit-Change-Number: 44299
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrew McRae
amcrae@chromium.org
Gerrit-CC: Andrew McRae
amcrae@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Aug 2020 05:51:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment