[coreboot-gerrit] Change in ...coreboot[master]: riscv: Simplify payload handling

[Jonathan Neuschäfer (Code Review)]

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31179 )

Change subject: riscv: Simplify payload handling
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

From a quick read, this looks good.
I'm slightly worried about the multiple asm blocks, though

https://review.coreboot.org/#/c/31179/3/src/arch/riscv/payload.c 
File src/arch/riscv/payload.c:

https://review.coreboot.org/#/c/31179/3/src/arch/riscv/payload.c@45 
PS3, Line 45: 	asm volatile("mv a0, %0" ::"r"(hart_id)
            : 		     : "a0");
            : 	asm volatile("mv a1, %0" ::"r"(fdt)
            : 		     : "a1");
            : 	asm volatile("mret");
I'd prefer to have this in one asm block, because I'd slightly paranoid that the compiler might move instructions between the asm blocks.