From a quick read, this looks good.
I'm slightly worried about the multiple asm blocks, though
Patch set 3:Code-Review +1
1 comment:
File src/arch/riscv/payload.c:
asm volatile("mv a0, %0" ::"r"(hart_id)
: "a0");
asm volatile("mv a1, %0" ::"r"(fdt)
: "a1");
asm volatile("mret");
I'd prefer to have this in one asm block, because I'd slightly paranoid that the compiler might move instructions between the asm blocks.
To view, visit change 31179. To unsubscribe, or for help writing mail filters, visit settings.