Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38127 )
Change subject: mb/ibase/mb899: Reformat code ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38127/2/src/mainboard/ibase/mb899/s... File src/mainboard/ibase/mb899/superio_hwm.c:
https://review.coreboot.org/c/coreboot/+/38127/2/src/mainboard/ibase/mb899/s... PS2, Line 28: #define FAN_CRUISE_CONTROL_DISABLED 0 Why? Those values were nicely aligned!
https://review.coreboot.org/c/coreboot/+/38127/2/src/mainboard/ibase/mb899/s... PS2, Line 57: {30, 86}, {33, 91}, {36, 96}, {39, 102}, I would add some extra spaces so that the numbers are nicely aligned
https://review.coreboot.org/c/coreboot/+/38127/2/src/mainboard/ibase/mb899/s... PS2, Line 73: // cpufan_temperature = FAN_TEMPERATURE_30DEGC; Isn't this just dead code?
https://review.coreboot.org/c/coreboot/+/38127/2/src/mainboard/ibase/mb899/s... PS2, Line 102: case FAN_CRUISE_CONTROL_SPEED: I don't see why this is an improvement