4 comments:
File src/mainboard/ibase/mb899/superio_hwm.c:
Patch Set #2, Line 28: #define FAN_CRUISE_CONTROL_DISABLED 0
Why? Those values were nicely aligned!
Patch Set #2, Line 57: {30, 86}, {33, 91}, {36, 96}, {39, 102},
I would add some extra spaces so that the numbers are nicely aligned
Patch Set #2, Line 73: // cpufan_temperature = FAN_TEMPERATURE_30DEGC;
Isn't this just dead code?
Patch Set #2, Line 102: case FAN_CRUISE_CONTROL_SPEED:
I don't see why this is an improvement
To view, visit change 38127. To unsubscribe, or for help writing mail filters, visit settings.