Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42076/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/42076/1/src/soc/amd/common/block/in...
PS1, Line 59: #define SPI_FIFO_DEPTH (SPI_FIFO_LAST_BYTE - SPI_FIFO)
I don't think this needs to be indented. […]
kept that the way it was, but you have a point there. fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91e65d922673f5c451a336ae013cb75f87a3fc98
Gerrit-Change-Number: 42076
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Jun 2020 17:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment