Change in coreboot[master]: soc/amd/common/spi: add and use define for last FIFO position
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
soc/amd/common/spi: add and use define for last FIFO position
The existing define for SPI_FIFO_DEPTH looked a bit suspicious, but turned out to be correct.
Change-Id: I91e65d922673f5c451a336ae013cb75f87a3fc98 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/include/amdblocks/spi.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/42076/1
diff --git a/src/soc/amd/common/block/include/amdblocks/spi.h b/src/soc/amd/common/block/include/amdblocks/spi.h index fec099d..6854a1a 100644 --- a/src/soc/amd/common/block/include/amdblocks/spi.h +++ b/src/soc/amd/common/block/include/amdblocks/spi.h @@ -55,7 +55,8 @@ #define SPI_RD4DW_EN_HOST BIT(15)
#define SPI_FIFO 0x80 -#define SPI_FIFO_DEPTH (0xc7 - SPI_FIFO) +#define SPI_FIFO_LAST_BYTE 0xc7 +#define SPI_FIFO_DEPTH (SPI_FIFO_LAST_BYTE - SPI_FIFO)
struct spi_config { /*
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42076/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/42076/1/src/soc/amd/common/block/in... PS1, Line 59: #define SPI_FIFO_DEPTH (SPI_FIFO_LAST_BYTE - SPI_FIFO) I don't think this needs to be indented. You are just introducing a new macro definition for last byte.
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42076
to look at the new patch set (#2).
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
soc/amd/common/spi: add and use define for last FIFO position
The existing define for SPI_FIFO_DEPTH looked a bit suspicious, but turned out to be correct.
Change-Id: I91e65d922673f5c451a336ae013cb75f87a3fc98 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/include/amdblocks/spi.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/42076/2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
Patch Set 2: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42076/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/42076/1/src/soc/amd/common/block/in... PS1, Line 59: #define SPI_FIFO_DEPTH (SPI_FIFO_LAST_BYTE - SPI_FIFO)
I don't think this needs to be indented. […]
kept that the way it was, but you have a point there. fixed.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
Patch Set 2: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
soc/amd/common/spi: add and use define for last FIFO position
The existing define for SPI_FIFO_DEPTH looked a bit suspicious, but turned out to be correct.
Change-Id: I91e65d922673f5c451a336ae013cb75f87a3fc98 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42076 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/include/amdblocks/spi.h 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/spi.h b/src/soc/amd/common/block/include/amdblocks/spi.h index fec099d..d226e0c 100644 --- a/src/soc/amd/common/block/include/amdblocks/spi.h +++ b/src/soc/amd/common/block/include/amdblocks/spi.h @@ -55,7 +55,8 @@ #define SPI_RD4DW_EN_HOST BIT(15)
#define SPI_FIFO 0x80 -#define SPI_FIFO_DEPTH (0xc7 - SPI_FIFO) +#define SPI_FIFO_LAST_BYTE 0xc7 +#define SPI_FIFO_DEPTH (SPI_FIFO_LAST_BYTE - SPI_FIFO)
struct spi_config { /*
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42076 )
Change subject: soc/amd/common/spi: add and use define for last FIFO position ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4925 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4924 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4923 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4922
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Felix Held (Code Review)
-
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)