Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )
Change subject: drivers/smmstore: Implement SMMSTORE version 2 ......................................................................
Patch Set 21:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40520/21/Documentation/drivers/smms... File Documentation/drivers/smmstorev2.md:
https://review.coreboot.org/c/coreboot/+/40520/21/Documentation/drivers/smms... PS21, Line 1: # SMM based flash storage driver Version 2
really outstanding job here
Thank you. I imagine this comment was meant to be resolved? (it was not)
https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/Kconf... File src/drivers/smmstore/Kconfig:
https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/Kconf... PS21, Line 12: default y if PAYLOAD_TIANOCORE
I feel that Y isn't the best default at the present time, since neither the default Tianocore packag […]
Good point. I'll change the default to n for now.
https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/smi.c File src/drivers/smmstore/smi.c:
https://review.coreboot.org/c/coreboot/+/40520/21/src/drivers/smmstore/smi.c... PS21, Line 144: usually
usually? are there conditions under which these are not true?
That comment was already in the existing code. I think it can be dropped.
https://review.coreboot.org/c/coreboot/+/40520/21/src/include/smmstore.h File src/include/smmstore.h:
https://review.coreboot.org/c/coreboot/+/40520/21/src/include/smmstore.h@43 PS21, Line 43: * FIXME: The data format isn't specified.
is this needed?
I'm not sure. I think not. Patrick Rudolph, happen to know if this is needed?