4 comments:
File Documentation/drivers/smmstorev2.md:
Patch Set #21, Line 1: # SMM based flash storage driver Version 2
really outstanding job here
Thank you. I imagine this comment was meant to be resolved? (it was not)
File src/drivers/smmstore/Kconfig:
Patch Set #21, Line 12: default y if PAYLOAD_TIANOCORE
I feel that Y isn't the best default at the present time, since neither the default Tianocore packag […]
Good point. I'll change the default to n for now.
File src/drivers/smmstore/smi.c:
Patch Set #21, Line 144: usually
usually? are there conditions under which these are not true?
That comment was already in the existing code. I think it can be dropped.
Patch Set #21, Line 43: * FIXME: The data format isn't specified.
is this needed?
I'm not sure. I think not. Patrick Rudolph, happen to know if this is needed?
To view, visit change 40520. To unsubscribe, or for help writing mail filters, visit settings.