Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 182:
(10 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/40faa1bf_fe49ee8e PS182, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/bdf1f741_7973cb18 PS182, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/e0712bd5_c7f1dc16 PS182, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/b3b40c07_0a2c9cdf PS182, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/f3348857_34f9b655 PS182, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/6e88338b_a1cfa219 PS182, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/1a5183e5_72b75d24 PS182, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/03c94dd3_5e2f8ef8 PS182, Line 97: if (dat & 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/fe87d1aa_f940cbdc PS182, Line 120: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/abf66fab_d7521a72 PS182, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)